Re: [PATCH v12 01/11] change used_by: specify both driver and domain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/17/2014 10:31 AM, Cedric Bosdonnat wrote:
>> --- a/src/util/virpci.c
>> > +++ b/src/util/virpci.c
>> > @@ -59,7 +59,10 @@ struct _virPCIDevice {
>> >      char          name[PCI_ADDR_LEN]; /* domain:bus:slot.function */
>> >      char          id[PCI_ID_LEN];     /* product vendor */
>> >      char          *path;
>> > -    const char    *used_by;           /* The domain which uses the device */
>> > +
>> > +    /* The driver:domain which uses the device */
>> > +    char          *used_by_drvname;
>> > +    char          *used_by_domname;
> Why changing from const char* to char*?
>

Just guessing that it's due to paranoia about the original string
disappearing. I can possibly understand that for used_by_domname, but
used_br_drvname is always a constant from a #define, so it's probably
not necessary.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]