Re: [PATCH 1/2] virDomainEvent refactoring to separate generic things from domain ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/19/2013 10:43 AM, Cédric Bosdonnat wrote:
> The idea behind this commit is to make use of the Domain event
> mechanism for other events like network ones. This introduces some
> renaming from virDomainEvent* to virOjbectEvent*.
> ---

> diff --git a/src/Makefile.am b/src/Makefile.am
> index ad39b74..8507b55 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -241,6 +241,10 @@ DOMAIN_CONF_SOURCES =						\
>  		conf/domain_nwfilter.c conf/domain_nwfilter.h	\
>  		conf/snapshot_conf.c conf/snapshot_conf.h
>  
> +OBJECT_EVENT_SOURCES =						\
> +		conf/object_event.h conf/object_event.c \
> +		conf/objec_event_private.h
> +

I didn't fully review this patch, but I did notice the typo here ('objec' vs
'object'). Make sure to run 'make distcheck' before resubmitting, I assume it
would have caught this.

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]