Re: [PATCH 1/5] remote: Clean up coding style and refactor remote connection opening
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 08/03/12 22:24, Eric Blake wrote:
On 08/03/2012 08:03 AM, Peter Krempa wrote:Remove spaces before fucntion calls and some other coding nits in somes/fucntion/function/parts of the remote driver and refactor getting of URI argument components into variables used by libvirt later on. --- src/remote/remote_driver.c | 292 +++++++++++++++++++++----------------------- 1 files changed, 142 insertions(+), 150 deletions(-)ACK; reasonable cleanups before the meat of the series.+ goto no_memory; + + if ((conn->uri && conn->uri->user) &&The () around the first && is redundant, but doesn't hurt.
I fixed the nits and pushed. I'll post a rebased and version of this set to get virObject support also into this connection driver.
Thanks for the review. Peter -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
[Virt Tools] [Libvirt Users] [Fedora Users] [Fedora Legacy] [Fedora Maintainers] [Fedora Desktop] [Fedora SELinux] [Big List of Linux Books] [Yosemite News] [Yosemite Photos] [KDE Users] [Fedora Tools]