Re: [PATCHv2 02/13] snapshot: use new virsh function for snapshot-list | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On 06/15/2012 03:38 AM, Peter Krempa wrote: > On 06/15/12 06:18, Eric Blake wrote: >> Operating on a list of snapshot objects looks so much simpler. >> In particular, since the helper function already trimmed out >> irrelevant entries, we no longer have quite so many special cases >> on finding the first snapshot to operate on. Also, vshTreePrint >> no longer has a generic callback struct; both clients now pass >> something different according to their own needs. >> >> * tools/virsh.c (cmdSnapshotList): Use previous patches. >> (vshTreeArrayLookup): Rename... >> (vshNodeListLookup): ...now that it only has one client. >> (cmdNodeListDevices): Adjust caller. >> --- >> >> v2: rename vshNodeListLookup >> >> tools/virsh.c | 225 >> +++++++++++---------------------------------------------- >> 1 file changed, 41 insertions(+), 184 deletions(-) >> > > ACK; the listing functions look much better after splitting out getter > code. Patches 1 and 2 were independent from your series, so I've pushed them now. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
[Virt Tools] [Libvirt Users] [Fedora Users] [Fedora Legacy] [Fedora Maintainers] [Fedora Desktop] [Fedora SELinux] [Big List of Linux Books] [Yosemite News] [Yosemite Photos] [KDE Users] [Fedora Tools]
