Google
  Web www.spinics.net

Re: [PATCH V4] nwfilter: Add support for ipset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 05/18/2012 04:19 PM, Eric Blake wrote:
On 05/14/2012 07:00 PM, Stefan Berger wrote:
+
+        flags = virBufferContentAndReset(&vb);
+
+        if (snprintf(buf, bufsize, "%s", flags)>= bufsize) {
+            virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                                   _("Buffer too small for IPSETFLAGS
type"));
Missed an instance of virStrncpy being nicer than snprintf.

Other than that, you hit all my review points, so you have my:

ACK.

If by Tuesday, no one speaks up with a counter-argument against this
patch as-is, then I say go ahead and apply with the nits fixed.

I pushed this now. If necessary, we may have to revert it.

   Stefan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Powered by Linux

Google
  Web www.spinics.net