Re: [PATCH] lxc: plug memory leak

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 09.11.2011 07:20, ajia@xxxxxxxxxx wrote:
> From: Alex Jia <ajia@xxxxxxxxxx>
> 
> Detected by Coverity. Leak introduced in commit 9d201a5.
> 
> * src/lxc/lxc_driver.c: Clean up on failure.
> 
> Signed-off-by: Alex Jia <ajia@xxxxxxxxxx>
> ---
>  src/lxc/lxc_driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index 37092bc..295fd6f 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -1856,7 +1856,7 @@ cleanup:
>  
>      if (err) {
>          virSetError(err);
> -        virResetError(err);
> +        virFreeError(err);
>      }
>  
>      return rc;

ACKed and pushed.

However, I've changed the title to:
lxc: free error object to avoid memory leak

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list