Re: [PATCH] Added minion module for VLAN management

[Adrian Likins <alikins@xxxxxxxxxx>]

Jasper Capel wrote:
> Adrian LIkins wrote:
> > Looks like a useful module, but I'm concerned about the use of 
> > ifconfig. It seems to be
> > on the way to being replaced with the 'ip' command.
> Thanks for your feedback. I'll change the module so it'll use the ip 
> command instead. I'm fairly new to submitting code, so is sending a 
> patch to my patch preferred, or should I send a revised patch?
   New patch is preferred. Or even better, especially if you have more 
patches, a git repo setup so we can pull your changes from it. Though
I noticed, we currently dont really explain that on the wiki, so I'll 
add that info shortly.

   Also, unit tests cases for the module are always welcome (see 
func/test/unittest/test_client.py for examples). Not sure how exactly to 
test
setting up vlans, but if you think of something clever, a unittest would 
be useful.

> And I was wondering if there's any nice way to store configurable 
> variables in Func; inside the module itself probably isn't the best 
> way to do this. :)
   Yup, all func modules have a self.options class now that corresponds 
to the config file in /etc/func/modules/$CLASSNAME.conf. I don't think
that API is particular well documented at the moment, so I'll add that 
shortly as well.

Adrian

> Kind regards,
>
> Jasper Capel
> Stone-IT

_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list