[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] [RFC] Print a watchdog message at KERN_WARNING level



On Thu, Feb 03, 2011 at 11:08:10PM +0100, Paul Bolle wrote:
> For messages like
>     NMI watchdog disabled for cpu0: unable to create perf event: -95
> 
> KERN_WARNING seems to be more appropriate than KERN_ERR. (Main benefit
> of the KERN_WARNING level is that Fedora's plymouth bootsplash should
> now hide them.)
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>

Hi Paul,

Thanks for the patch.  I actually maintain this file upstream.  I am
concerned about the error you are seeing, -95.  Is it possible you can
provide me a 'dmesg' log of your boot up.  I want to see what chipset the
perf subsystem thinks it found.

I may want to handle this error a little bit differently than the patch
you provided below.

Thanks,
Don

> ---
> Yes, the changed line is getting very long, but that is apparently not a
> problem in this file.
> 
>  kernel/watchdog.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index f37f974..1c2ffe1 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -363,7 +363,7 @@ static int watchdog_nmi_enable(int cpu)
>  		goto out_save;
>  	}
>  
> -	printk(KERN_ERR "NMI watchdog disabled for cpu%i: unable to create perf event: %ld\n",
> +	printk(KERN_WARNING "NMI watchdog disabled for cpu%i: unable to create perf event: %ld\n",
>  	       cpu, PTR_ERR(event));
>  	return PTR_ERR(event);
>  
> -- 
> 1.7.4
> 
> _______________________________________________
> kernel mailing list
> kernel@xxxxxxxxxxxxxxxxxxxxxxx
> https://admin.fedoraproject.org/mailman/listinfo/kernel
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel


[Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Maintainers]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Deep Creek Hot Springs]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [Yosemite Photos]     [Linux Apps]     [KDE Users]     [Fedora Tools]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

Powered by Linux