[389-devel] [ds.git] [PATCH 1/1]: Do not check port availability during forced setup

["Jeroen van Meeuwen (Kolab Systems)" <vanmeeuwen@xxxxxxxxxxxx>]

Hi there,

In a scenario where I'm trying to setup a 389 Directory Server automatically, 
I ran into an issue with checking ports - no ports nor any networking, are 
available when I execute the setup. FWIW, I'm bootstrapping the setup for a 
live image.

The problem seems to be in ldap/admin/src/scripts/DSDialogs.pm, at line 69, 
which checks for the port to be available without taking into account whether 
or not the setup is supposed to continue (even without a port).

Attached is a patch.

Kind regards,

Jeroen van Meeuwen

-- 
Systems Architect, Kolab Systems AG

e: vanmeeuwen at kolabsys.com
m: +44 74 2516 3817
w: http://www.kolabsys.com

pgp: 9342 BF08

>From 76a40ca5d454b77924207180d9ddef76e90e5ce5 Mon Sep 17 00:00:00 2001
From: "Jeroen van Meeuwen (Kolab Systems)" <vanmeeuwen@xxxxxxxxxxxx>
Date: Sat, 21 Apr 2012 14:15:57 +0100
Subject: [PATCH] Suppress alert on unavailable port with forced setup

---
 ldap/admin/src/scripts/DSDialogs.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ldap/admin/src/scripts/DSDialogs.pm b/ldap/admin/src/scripts/DSDialogs.pm
index 60bc115..08c8b2b 100644
--- a/ldap/admin/src/scripts/DSDialogs.pm
+++ b/ldap/admin/src/scripts/DSDialogs.pm
@@ -66,7 +66,7 @@ my $dsport = new Dialog (
         my $res = $DialogManager::SAME;
         if ($ans !~ /^\d+$/) {
             $self->{manager}->alert("dialog_dsport_invalid", $ans);
-        } elsif (!portAvailable($ans)) {
+        } elsif (!portAvailable($ans) && !$self->{manager}->{setup}->{force}) {
             $self->{manager}->alert("dialog_dsport_error", $ans);
         } else {
             $res = $DialogManager::NEXT;
-- 
1.7.7.6

Attachment: signature.asc
Description: This is a digitally signed message part.

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel