Re: [PATCH] virt-manager: remove disambiguity in "free space" dialog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Guido Günther wrote:
> On Mon, Feb 09, 2009 at 08:21:29AM +0000, Mark McLoughlin wrote:
>> Hi Guido,
>> On Sat, 2009-02-07 at 21:34 +0100, Guido Günther wrote:
>>> -                res = self.err.yes_no(_("Not Enough Free Space"), ret[1])
>>> +                res = self.err.yes_no(_("Not Enough Free Space"), _("%s. Continue anyway?") % ret[1])
>>>                  if not res:
>>>                      return False
>> See the GNOME HIG:
>> I think what you want here is to change the buttons to Cancel/Continue -
>> i.e. a Cancel button and an affirmative verb button.
> I've changed this to "Ok/Cancel" in the attached patch. A simple Ok
> looks more obvious to me in this case since I'd be unsure to continue
> with what (it's not creating wizard in the case of add_hardware) and the
> only thing the user has to do is to acknowledge.
>  -- Guido

Thanks, applied now:

- Cole

et-mgmt-tools mailing list

[Home]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Red Hat 9 Bible]     [Fedora Bible]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Powered by Linux