Re: [RFC]Re: [libvirt][RFC][PATCH]virt-managercallsmigration API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

As a result of migration test in my environment that applied this patch,
there is not a problem.

If not comment, please apply this patch.


Thanks,
Shigeki Sakamoto.

> Hi, Shigeki
> 
> When you plan to post "commit ready" patch?
> 
> Thanks
> Atsushi SAKAI
> 
> 
> "S.Sakamoto" <fj0588di@xxxxxxxxxxxxxxxxx> wrote:
> 
> > Hi,
> > 
> > I make the prototype patch.
> > 
> > This patch is displayed destination host in a sub-menu, as follows.
> > 
> >     right-click
> >       |
> >       +-  Run
> >           Pause
> >           Shutdown
> >           --------
> >           Migrate ----> host1.example.com
> >                         host2.example.com
> >                         host3.example.com
> > 
> > The item that display in a sub-menu is the host
> > which is a state of ACTIVE or INACTIVE besides the source host.
> > When the host which is a state of ACTIVE or INACTIVE besides a source host doesn't exist,
> > "(None)" that is insensitive is displayed, as follows.
> > 
> >     right-click
> >       |
> >       +-  Run
> >           Pause
> >           Shutdown
> >           --------
> >           Migrate ----> (None)
> > 
> > 
> >  domain.py  |    6 ++++
> >  engine.py  |   36 ++++++++++++++++++++++++++++
> >  manager.py |   78 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> >  3 files changed, 117 insertions(+), 3 deletions(-)
> > 
> > 
> > 
> > Thanks,
> > Shigeki Sakamoto.
> > 
> > > Hi, Daniel
> > > 
> > > Sorry for delaying response.
> > > 
> > > Thank you for your suggestions. I understand. 
> > > I will make the prototype patch!
> > > 
> > > Thanks
> > > Shigeki Sakamoto.
> > > 
> > > > On Fri, Sep 19, 2008 at 06:43:37PM +0900, S.Sakamoto wrote:
> > > > > > 
> > > > > > > You probably want to send this to et-mgmt-list, which is where virt-manager
> > > > > > > development happens,
> > > > > > 
> > > > > > OK. For this, I tried to hear in et-mgmt-list.
> > > > > > 
> > > > > 
> > > > > I'm sorry to be pressing, but would you give me a comment on this patch for
> > > > > going on the next step to migrate from virt-manager ? 
> > > > > I attached screenshots this patch shows.
> > > > 
> > > > I think rather than having it popup a new window with a list of hosts to
> > > > migrate to, you could just have a sub-menu where you choose the destination
> > > > host directly.
> > > > 
> > > > eg,
> > > > 
> > > >     right-click
> > > >       |
> > > >       +-  Run
> > > >           Pause
> > > >           Shutdown
> > > >           --------
> > > >           Migrate ----> host1.example.com
> > > >                         host2.example.com
> > > >                         host3.example.com
> > > >                         ...etc...
> > > > 
> > > > When the user selects one of these hosts, it'd popup a confirmation
> > > > window, and do the neccessary migration checks, and then allow the
> > > > admin to confirm to start the migration.
> > > > 
> > > > > > > I sent an e-mail last month with proposals for doing this within libvirt.  I put
> > > > > > > up all of the information I have in the libvirt wiki here:
> > > > > > > 
> > > > > > > http://wiki.libvirt.org/page/TodoPreMigrationChecks
> > > > > > 
> > > > > > Thank you for your information. I see above libvirt wiki and I have a few 
> > > > > > idea adding checks within libvirt. These point of view are Guest and Host sanity
> > > > > > in BASIC CHECKS. How about this points ?
> > > > > > 
> > > > > >  1)Guest sanity is checking whether already existing or not on the destination.
> > > > > >    Otherwise the uniqueness of the domain(UUID, name) are lost.
> > > > > >    * I think that it is right to check this in libvirt. How do you think this ?
> > > > 
> > > > Yes, checking for name/uuid uniqueness has to be done inside libvirt by
> > > > each hypervisor driver according to their own rules.
> > > > 
> > > > > >  2)Host sanity is checking whether a migration flag is ON at each virtualization.
> > > > 
> > > > virt-manager will need to check the kind of things on the TodoPreMigrationChecks
> > > > wiki page.
> > > > 
> > > > 
> > > > Daniel
> > > > -- 
> > > > |: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
> > > > |: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
> > > > |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> > > > |: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
> > > > 
> > > > _______________________________________________
> > > > et-mgmt-tools mailing list
> > > > et-mgmt-tools@xxxxxxxxxx
> > > > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> > > 
> > > _______________________________________________
> > > et-mgmt-tools mailing list
> > > et-mgmt-tools@xxxxxxxxxx
> > > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> 
> 
> _______________________________________________
> et-mgmt-tools mailing list
> et-mgmt-tools@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> 

Attachment: migrate_submenu.patch
Description: Binary data

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux