Re: [PATCH 2/2] Move sshpw handling out of Anaconda

[Radek Vykydal <rvykydal@xxxxxxxxxx>]

First thanks for taking over the BZ. One question below:

On 06/08/2012 07:31 AM, Jesse Keating wrote:

> diff --git a/pyanaconda/sshd.py b/pyanaconda/sshd.py
> deleted file mode 100644
> index b6c9372..0000000
> --- a/pyanaconda/sshd.py
> +++ /dev/null
> @@ -1,90 +0,0 @@
> -# sshd.py
> -# Configuring the sshd daemon from Anaconda.
> -#
> -# Copyright (C) 2009  Red Hat, Inc.
> -#
> -# This copyrighted material is made available to anyone wishing to use,
> -# modify, copy, or redistribute it subject to the terms and conditions of
> -# the GNU General Public License v.2, or (at your option) any later version.
> -# This program is distributed in the hope that it will be useful, but WITHOUT
> -# ANY WARRANTY expressed or implied, including the implied warranties of
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
> -# Public License for more details.  You should have received a copy of the
> -# GNU General Public License along with this program; if not, write to the
> -# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> -# 02110-1301, USA.  Any Red Hat trademarks that are incorporated in the
> -# source code or documentation are not subject to the GNU General Public
> -# License and may only be used or replicated with the express permission of
> -# Red Hat, Inc.
> -#
> -
> -
> -import logging
> -import os, sys
> -log = logging.getLogger("anaconda")
> -
> -import iutil
> -import users
> -from flags import flags
> -from constants import ROOT_PATH
> -
> -def createSshKey(algorithm, keyfile):
> -    path = '/etc/ssh/%s' % (keyfile,)
> -    argv = ['-q','-t',algorithm,'-f',path,'-C','','-N','']
> -    if os.access(path, os.R_OK):
> -        return
> -    log.debug("running \"%s\"" % (" ".join(['ssh-keygen']+argv),))
> -
> -    so = "/tmp/ssh-keygen-%s-stdout.log" % (algorithm,)
> -    se = "/tmp/ssh-keygen-%s-stderr.log" % (algorithm,)
> -    iutil.execWithRedirect('ssh-keygen', argv, stdout=so, stderr=se)
> -
> -def doSshd(anaconda):
> -    if flags.sshd:
> -        # we need to have a libuser.conf that points to the installer root for
> -        # sshpw, but after that we start sshd, we need one that points to the
> -        # install target.
> -        luserConf = users.createLuserConf(instPath="")
> -        handleSshPw(anaconda)
> -        startSsh()
> -        del(os.environ["LIBUSER_CONF"])
> -    else:
> -        log.info("sshd: not enabled, skipping.")
> -
> -    users.createLuserConf(ROOT_PATH)

Seems like we used to run this independently of sshd option.
Won't we miss it in non-sshd installs? Just making sure, perhaps
we get the libuser.conf already in lorax.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list